Merged
Conversation
karinaA7
force-pushed
the
add-new-statistics
branch
from
c5c3d3d to
a978811
Compare
Collaborator
|
Since you've added new statistic methods to DataStats, they are now printed whenever |
karinaA7
force-pushed
the
add-new-statistics
branch
from
a978811 to
df3b75f
Compare
xJoskiy
reviewed
Feb 27, 2026
xJoskiy
reviewed
Feb 27, 2026
xJoskiy
reviewed
Feb 27, 2026
xJoskiy
reviewed
Feb 27, 2026
karinaA7
force-pushed
the
add-new-statistics
branch
2 times, most recently
from
9dab0de to
742d809
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
karinaA7
force-pushed
the
add-new-statistics
branch
from
742d809 to
8ef7d19
Compare
xJoskiy
reviewed
Feb 28, 2026
karinaA7
force-pushed
the
add-new-statistics
branch
from
8ef7d19 to
c5b7a1b
Compare
xJoskiy
reviewed
Feb 28, 2026
xJoskiy
reviewed
Feb 28, 2026
xJoskiy
reviewed
Feb 28, 2026
xJoskiy
reviewed
Feb 28, 2026
karinaA7
force-pushed
the
add-new-statistics
branch
from
c5b7a1b to
03a3e42
Compare
xJoskiy
reviewed
Mar 2, 2026
xJoskiy
reviewed
Mar 2, 2026
xJoskiy
reviewed
Mar 2, 2026
xJoskiy
reviewed
Mar 2, 2026
karinaA7
force-pushed
the
add-new-statistics
branch
from
03a3e42 to
b52df00
Compare
karinaA7
force-pushed
the
add-new-statistics
branch
from
b52df00 to
fe1f418
Compare
karinaA7
force-pushed
the
add-new-statistics
branch
2 times, most recently
from
9237253 to
d848454
Compare
xJoskiy
reviewed
Mar 4, 2026
karinaA7
force-pushed
the
add-new-statistics
branch
from
d848454 to
0e8419f
Compare
xJoskiy
reviewed
Mar 7, 2026
| return GetWhitespaceCount(index, CharPosition::kLast); | ||
| } | ||
|
|
||
| Statistic DataStats::GetSpecialCharsCount(size_t index) const { |
Collaborator
There was a problem hiding this comment.
The naming does not reflect the actual purpose of this function. Should better name it like GetNumberOfRowsWithSpecialChars
xJoskiy
reviewed
Mar 7, 2026
Comment on lines
+923
to
+927
| Statistic DataStats::GetLeadingWhitespaceCount(size_t index) const { | ||
| return GetWhitespaceCount(index, CharPosition::kFirst); | ||
| } | ||
|
|
||
| Statistic DataStats::GetTrailingWhitespaceCount(size_t index) const { |
Collaborator
There was a problem hiding this comment.
The same with these functions. GetNumberOfRowsWithTrailingWhitespaces
Collaborator
|
Also it is highly recommended to resolve conversations when issues are fixed |
karinaA7
force-pushed
the
add-new-statistics
branch
2 times, most recently
from
dfbf804 to
1d58d0b
Compare
chernishev
force-pushed
the
add-new-statistics
branch
from
1d58d0b to
c36246a
Compare
Collaborator
|
LGTM |
xJoskiy
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New statistics:
whitespaceOnlyCount - the number of lines that consist only of whitespace characters
(space and tab)
firstCharFrequency / lastCharFrequency - the most common first/ last character in the column lines and the number of its occurrences
leadingWhitespaceCount / trailingWhitespaceCount - the number of lines with spaces at the beginning or at the end
specialCharsCount
Number of lines containing special characters